feat: Refactor workflows to use custom commands #89
Conversation
![gemini-cli[bot]](https://avatars.githubusercontent.com/in/1473539?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a great PR that refactors the workflows to use the new custom commands feature. This will make the workflows much more maintainable and easier to customize. The changes are well-implemented and the documentation is clear. I only have one minor suggestion.
jerop
force-pushed
the
feat/custom-commands
branch
from
8c3f0aa to
4d68e59
Compare
jerop
force-pushed
the
feat/custom-commands
branch
from
4d68e59 to
0367f21
Compare
There was a problem hiding this comment.
I like this, it's really clean. FWIW, here's a pattern we do elsewhere (e.g. downloading a default linter config unless the user provides their own): https://github.com/abcxyz/actions/blob/f26869a425d0b0217b9c8ad7e3f6ab70547272c9/.github/actions/lint-go/action.yml#L48-L70
This commit refactors the existing workflows to use the new custom commands feature in the Gemini CLI. This makes the workflows more maintainable and easier to read, and it also allows users to easily customize the prompts. The following changes were made: - Created `.toml` files for each custom command in the `.gemini/commands` directory. - Updated the `.gitignore` file to include the `.gemini/commands` directory. - Updated the workflow files to use the new custom commands. - Updated the `README.md` files to reflect the changes. - Added the new workflows and commands to the repository for dogfooding.
jerop
force-pushed
the
feat/custom-commands
branch
from
0367f21 to
478fe07
Compare
There was a problem hiding this comment.
📋 Review Summary
This pull request refactors the existing workflows to use the new custom commands feature in the Gemini CLI. This is a great improvement that will make the workflows more maintainable and easier to read. I've left a few comments to address some typos in the new command files.
🔍 General Feedback
- The use of custom commands is a great way to simplify the workflows and make them more reusable.
- The new
tomlfiles are well-structured and easy to understand. - The documentation has been updated to reflect the changes.
|
Really like this. It will make it easier as well for us to add new workflows for the specialized agents and extensions that we're working on releasing very soon. |
|
@jerop I'd love to get this in to clean things up |
This commit refactors the existing workflows to use the new custom commands feature in the Gemini CLI. This makes the workflows more maintainable and easier to read, and it also allows users to easily customize the prompts.
The following changes were made:
.tomlfiles for each custom command in the.gemini/commandsdirectory..gitignorefile to include the.gemini/commandsdirectory.README.mdfiles to reflect the changes.More context in #76
This is a POC; slash commands don't work in headless mode yet - google-gemini/gemini-cli#5435